Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fragile WebUSB error matching code. #1122

Merged
merged 1 commit into from
May 22, 2023

Conversation

microbit-matt-hillsdon
Copy link
Collaborator

The text now appears to be prefixed, we have e.g.

DOMException: Failed to execute 'requestDevice' on 'USB': No device selected.

Probably still worth it unfortunately.

The text now appears to be prefixed, we have e.g.

> DOMException: Failed to execute 'requestDevice' on 'USB': No device selected.

Probably still worth it unfortunately.
@github-actions
Copy link

Preview build will be at
https://review-python-editor-v3.microbit.org/webusb-errors/

@microbit-matt-hillsdon
Copy link
Collaborator Author

Once built I'll ensure we can trigger each case.

@microbit-matt-hillsdon
Copy link
Collaborator Author

Once built I'll ensure we can trigger each case.

Confirmed.

Copy link
Collaborator

@microbit-robert microbit-robert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@microbit-matt-hillsdon microbit-matt-hillsdon merged commit 879cfb2 into main May 22, 2023
@microbit-matt-hillsdon microbit-matt-hillsdon deleted the webusb-errors branch May 22, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants